Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle scaled table rows (for smallmatrix) properly in CHTML and SVG #621

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 12, 2021

This PR fixes the smallmatrix environment by properly handling the scaled mrows so that the widths and separations are correct. The problem was particularly apparent in SVG output, but also affected the separations in CHTML output. In addition the colored backgrounds for cells and rows in SVG matrices were not always properly sized, and this fixes that as well.

@dpvc dpvc added this to the 3.1.3 milestone Mar 12, 2021
@dpvc dpvc requested a review from zorkow March 12, 2021 13:22
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Divisions are always expensive. I suggest to turn most of them into multiplications.

@dpvc
Copy link
Member Author

dpvc commented Mar 19, 2021

Divisions are always expensive. I suggest to turn most of them into multiplications.

Good idea. Done.

@dpvc dpvc requested a review from zorkow March 22, 2021 14:11
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit bd135a7 into develop Mar 29, 2021
@dpvc dpvc deleted the fix-smallmatrix branch March 29, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants