Combine unknown characters into a common <text> element. (mathjax/MathJax#2672) #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR groups runs of unknown characters into a single
<text>element in SVG output, just as was implemented in CHTML in #734 in commit 115c542. It also makes the computation of the bounding box consistent with that, since text with combining characters will have a different width when grouped together than when handled separately. (The bounding box computations were wrong for CHTML, but since most of the CHTML doesn't depend on those computations, not wasn't caught.) For example, with\text{🇦🇩}, the output was correct but the bounding box computation was wrong.Resolves issue mathjax/MathJax#2672.