Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't replace the stylesheet when option adaptiveCSS is false #2454

Closed
mt4c opened this issue Jun 12, 2020 · 2 comments
Closed

Don't replace the stylesheet when option adaptiveCSS is false #2454

mt4c opened this issue Jun 12, 2020 · 2 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3 v3.1
Milestone
3.1.0

Comments

@mt4c
Copy link

mt4c commented Jun 12, 2020

Issue Summary

When the adaptiveCSS is false, there is no need to replace the stylesheet ( the "MJX-CHTML-styles" element ) on typesetting. It cause flicker on old version browsers and slow devices.

Steps to Reproduce:

  1. Typeset some math on the page.
  2. Typeset some other math on the page. The old maths flicker.

Technical details:

  • MathJax Version: 3
  • Client OS: Android
  • Browser: Chrome 52

Supporting information:

I copy the stylesheet and modify the font-family name. Make the font family styles "!important". Insert it in the page. Then the flickers disappear.
dpvc added a commit to mathjax/MathJax-src that referenced this issue Jun 15, 2020
@dpvc
Don't replace CHTML stylesheet when adaptiveCSS is not in effect, or …
dc0c2f7 
…oin SVG output. (mathjax/MathJax#2454)
@dpvc dpvc mentioned this issue Jun 15, 2020
Merged
@dpvc
Copy link
Member

dpvc commented Jun 15, 2020

Thanks for the report. I've made a pull request to resolve the issue.

@dpvc dpvc added Accepted Issue has been reproduced by MathJax team Ready for Review Test Needed v3 labels Jun 15, 2020
dpvc added a commit to mathjax/MathJax-src that referenced this issue Jun 16, 2020
@dpvc
Merge pull request #516 from mathjax/issue2454
f6c9be7 
Don't replace stylesheet unnecessarily. (mathjax/MathJax#2454)
@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Jun 16, 2020
@dpvc dpvc added this to the 3.1.0 milestone Aug 25, 2020
@dpvc dpvc added Fixed v3.1 and removed Merged Merged into develop branch labels Aug 25, 2020
@dpvc
Copy link
Member

dpvc commented Aug 25, 2020

Fixed in v3.1 released today.

@dpvc dpvc closed this as completed Aug 25, 2020
@dependabot-preview dependabot-preview bot mentioned this issue Aug 26, 2020
Closed
@dependabot dependabot bot mentioned this issue Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3 v3.1
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@dpvc @mt4c