Module doesn't provide get_supported_login_types()

[Half-Shot]

Needed in https://github.com/matrix-org/synapse/blob/b2b86990705de8a099093ec141ad83e09f182034/synapse/handlers/auth.py#L95-L100

Otherwise, this doesn't appear to expose the correct flow for GET /login

[clokep]

The workaround for this is to enable password authentication manually in the config.

[richvdh]

it only provides password, so doesn't need to provide get_supported_login_types ?

[Half-Shot]

My point is that I want the module to return LoginType.PASSWORD, as otherwise users need to remember to enable password_enabled in the synapse configuration. If you don't do this, LDAP won't work as no flows will be returned.

[richvdh]

you mean they have to remember not to disable password_enabled, since it's enabled by default?

[richvdh]

tbh if I disabled password login and found I could still log in with a password, I would be...surprised.

[Half-Shot]

Well, I've always read password_enabled as Synapse password authentication as oppose to LDAP password authentication, so I can see where this gets confused. But granted, it could include LDAP.

I feel like we could at least document that adding the password_provider isn't enough, and you need to enable this too, even if it is by default.