Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Errors from the manhole go to the logfile rather than the manhole #4768

Closed
richvdh opened this issue Feb 28, 2019 · 6 comments
Closed

Errors from the manhole go to the logfile rather than the manhole #4768

richvdh opened this issue Feb 28, 2019 · 6 comments
Labels
A-Logging Synapse's logs (structured or otherwise). Not metrics.

Comments

@richvdh
Copy link
Member

richvdh commented Feb 28, 2019

This is only happening on matrix.org, and I'm sure it didn't previously:

in the manhole:

>>> slkghdklg
>>> 

meanwhile, in the log:

2019-02-28 17:14:03,867 - twisted - 240 - ERROR -  - Traceback (most recent call last):
2019-02-28 17:14:03,884 - twisted - 240 - ERROR -  -   File /usr/local/lib/python3.6/code.py, line 91, in runcode
2019-02-28 17:14:03,896 - twisted - 240 - ERROR -  -     exec(code, self.locals)
2019-02-28 17:14:03,908 - twisted - 240 - ERROR -  -   File <console>, line 1, in <module>
2019-02-28 17:14:03,917 - twisted - 240 - ERROR -  - NameError: name 'slkghdklg' is not defined
@richvdh
Copy link
Member Author

richvdh commented Feb 28, 2019

I can't figure out what is different between matrix.org and sw1v.org that could cause this.

@erikjohnston
Copy link
Member

Is this because we're capturing stderr?

@richvdh
Copy link
Member Author

richvdh commented Mar 4, 2019

hrm, could be. I think I've disabled that on sw1v. Yet another reason we need to fix #1539 if so.

@richvdh
Copy link
Member Author

richvdh commented Mar 4, 2019

hrm it seems to work ok on sw1v.org even if I allow it to redirect stdio.

@neilisfragile neilisfragile added A-Logging Synapse's logs (structured or otherwise). Not metrics. z-p2 (Deprecated Label) labels Mar 5, 2019
@richvdh
Copy link
Member Author

richvdh commented Mar 6, 2019

neil this is pretty painful for ops things. I'm going to bump it up.

@richvdh richvdh added p1 and removed z-p2 (Deprecated Label) labels Mar 6, 2019
@richvdh
Copy link
Member Author

richvdh commented Apr 9, 2019

turns out it was being swallowed by the sentry exception hook. hopefully fixed by #5035.

@richvdh richvdh closed this as completed May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Logging Synapse's logs (structured or otherwise). Not metrics.
Projects
None yet
Development

No branches or pull requests

3 participants