Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes to feedback app #15

Merged
merged 2 commits into from
Feb 27, 2025
+87 −83
Merged

Several fixes to feedback app #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72f3b12
fix: Don't send feedback with no rating and don't send duplicated fee…
lfzawacki Feb 26, 2025
b0821af
fix(form): drop the feedback prefix in some form answers
lfzawacki Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions backend/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,15 @@ app.post('/feedback/submit', async (req, res) => {
const cleanFeedback = JSON.parse(JSON.stringify(completeFeedback, (key, value) => value === undefined ? undefined : value));
const logLevel = logger.level;

console.log(`${new Date().toISOString()} custom-feedback [${logLevel}] : CUSTOM FEEDBACK LOG: ${JSON.stringify(cleanFeedback)}`);
if (cleanFeedback.rating) {
console.log(`${new Date().toISOString()} custom-feedback [${logLevel}] : CUSTOM FEEDBACK LOG: ${JSON.stringify(cleanFeedback)}`);
} else {
return logger.info(`Not logging feedback without rating`);
}

if (FEEDBACK_URL) {
await redisClient.set(feedbackKey, JSON.stringify(completeFeedback), { EX: 3600 });
await redisClient.set(feedbackKey, JSON.stringify(completeFeedback), { EX: 3600 });

if (FEEDBACK_URL) {
request.post(
FEEDBACK_URL,
{ json: completeFeedback },
Expand Down
Loading