Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMs are broken if user changes nick #107

Open
kdkasad opened this issue Mar 19, 2021 · 1 comment
Open

DMs are broken if user changes nick #107

kdkasad opened this issue Mar 19, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kdkasad
Copy link
Contributor

kdkasad commented Mar 19, 2021

If the user changes their nick using the /NICK command, the nick variable never gets updated. But kirc uses this nick value to check if a message was a message sent directly to the user's nick.

To reproduce:

  1. Log on to an IRC server
  2. Send yourself a DM (@<nick> test message). This should work as expected.
  3. Change your nick (/NICK <nick2>)
  4. Send yourself a DM to this new nick (@<nick2> test message).

The message from step 4 will not be highlighted in cyan as a DM should be. Instead, it'll have your nick (i.e. <nick2>) in brackets as if it was a channel name.

@mcpcpc mcpcpc self-assigned this Mar 19, 2021
@mcpcpc mcpcpc added the bug Something isn't working label Mar 19, 2021
@stefan11111
Copy link
Contributor

Does this still happen?
I tested this and it works here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants