Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): remove redirects that reference to deleted docs #126

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Feb 7, 2025

Description

remove redirects that reference to deleted docs.

Motivation

To be written

Additional details

Related issues and pull requests

@yin1999 yin1999 force-pushed the feat-remove-deleted-slugs branch from a8b5e22 to 678d676 Compare February 12, 2025 07:16
@yin1999 yin1999 marked this pull request as ready for review February 12, 2025 07:18
return Ok(());
}

validate_pairs(&pairs, locale)?;
Copy link
Member Author

@yin1999 yin1999 Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to check the internal to_url: in check_url_invalid_symbols() function, we shoud check if the doc related to to_url exists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We check for the path but not the doc. I'll fix this as a follow-up.

Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! thanks

return Ok(());
}

validate_pairs(&pairs, locale)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We check for the path but not the doc. I'll fix this as a follow-up.

@fiji-flo fiji-flo merged commit 7f99fc6 into mdn:main Feb 14, 2025
1 check passed
@yin1999 yin1999 deleted the feat-remove-deleted-slugs branch February 14, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants