Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xyz): update xyz build #10866

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix(xyz): update xyz build #10866

merged 3 commits into from
Apr 8, 2024

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Apr 8, 2024

Summary

Update the xyz build

  • should fix live samples
  • clean up

@fiji-flo
fix(xyz): update xyz build
6ebfd1b 
- should fix live samples
- clean up
@fiji-flo fiji-flo requested a review from caugner April 8, 2024 11:12
@fiji-flo fiji-flo requested a review from a team as a code owner April 8, 2024 11:12
caugner
caugner requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow changes LGTM, but one comment about the Cloud Function change.

@fiji-flo fiji-flo requested a review from caugner April 8, 2024 13:19
@fiji-flo fiji-flo merged commit 51b39a9 into main Apr 8, 2024
13 checks passed
@fiji-flo fiji-flo deleted the update-xyz branch April 8, 2024 13:36
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
cloud-function github-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiji-flo @caugner