feat(interactive-examples): support HTML examples #12633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
reviewed
Feb 19, 2025
@LeoMcA Should I replicate these tests to verify? If so, can you please share instructions? |
argl
approved these changes
Feb 19, 2025
caugner
approved these changes
Feb 20, 2025
| background: var(--background-secondary); | ||
| border-bottom: 1px solid var(--border-secondary); | ||
| display: flex; | ||
| flex-shrink: 0; |
There was a problem hiding this comment.
Nit: Since flex-grow defaults to 0 (unless set elsewhere I don't see), we can use the short-hand for clarity (!?).
Suggested change
| flex-shrink: 0; | |
| flex: 0; |
There was a problem hiding this comment.
I think it would have to be flex: 0 0;, and at least to me using flex-shrink directly is clearer: I think "this flex item can't shrink" rather than "wait what order are the arguments in flex again"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Look at second commit onwards for easier diff.
Summary
https://github.com/orgs/mdn/discussions/782
Adds support for HTML examples, including:
How did you test this change?
Another round of snapshot image diff testing to do, alongside rari diff testing.