feature(interactive-examples): add support for WAT examples #12654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
argl
changed the title
github-actions
bot
added
the
dependencies
argl
commented
Feb 24, 2025
LeoMcA
reviewed
Feb 25, 2025
LeoMcA
changed the title
Co-authored-by: Leo McArdle <[email protected]>
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support WAT with the component based interactive examples
Problem
Getting the 4th variant of the interactive examples on par with the old version.
Solution
Add the needed logic to compile WAT->WASM client-side and pass it via a data-url into the javascript boilerplate code.
How did you test this change?
Compared the console output of the old and the new version of WAT interactive examples. No differences were found over 61 examples.