fix(kumascript): mention path in render error message #8936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmth
reviewed
May 26, 2023
bsmth
approved these changes
May 26, 2023
caugner
changed the title
caugner
force-pushed
the
mention-page-in-macro-render-failure
branch
from
9ba6fff to
84b2342
Compare
fiji-flo
added a commit
that referenced
this pull request
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a macro fails, the console error message mentions only the macro name and the error message, making it hard to identify which page the macro failed on.
Solution
Add the document path to the error message.
Screenshots
Before
After
How did you test this change?
Ran
yarn build --locale en-usin a VSCode Debug Console, setting a breakpoint in the catch block.