fix: prevent live-sample render errors killing the whole build #9155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #9154
Not entirely sure what the underlying issue is here: with playground, our routing logic for localised cross document live samples must have changed, and now we can't find some. Rather than debugging and fixing that, I'm letting them remain broken, but preventing them from killing the entire build.
An example of a file which fails is
yarn build files/fr/learn/forms/how_to_structure_a_web_form/index.md
like so:When building all documents, this would error out the entire build for that locale. For some reason we don't catch this in our action and error out the entire action - instead we seem to plod on, only uploading the documents which managed to be built prior to that error.
In summary, this:
On monday we should debug and fix: