fix(livesamples): use correct legacy url #9158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not use the legacy URL in LiveSampleURL.ejs
caugner
approved these changes
Jun 26, 2023
kumascript/macros/LiveSampleURL.ejs
Outdated
|
|
||
| if ($1 && $1.length > 0) { | ||
| mdn.deprecatedParams("The second parameter of 'LiveSampleURL' is deprecated"); |
There was a problem hiding this comment.
Ideally, the message would have an actionable suggestion on how to proceed. I guess in this case the original example has to be copied into the page, right?
kumascript/macros/LiveSampleURL.ejs
Outdated
| var pagePath = env.url; | ||
| let pagePath = env.url; | ||
| let baseUrl = env.live_samples.base_url; | ||
| let samplePath = `${pagePath}/runner.html`.replace(/\/\/+/g, "/"); | ||
|
|
||
| if ($1 && $1.length > 0) { |
There was a problem hiding this comment.
Since you're cleaning up the macro anyways, can you assign $0 and $1 to variables id and url or similar to avoid referencing $0 and $1 below?
LeoMcA
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We did not use the legacy URL in LiveSampleURL.ejs
Problem
Live samples translated from another page (deprecated), resulted in to 404 iframe.
Solution
Use the legacy url in LiveSampleURL.ejs to point to the legacy live sample.
Screenshots
Before
After
How did you test this change?
https://developer.mozilla.org/en-US/docs/Learn/Forms/How_to_build_custom_form_controls
With:
Use a
yarn build files/en-us/learn/forms/how_to_build_custom_form_controls/index.mdand check that the iframes in the resulting html file havelive-samples.mdn.mozilla.netas domain if they are not using therunner.html.