fix: update of linked external dependency

medikoo · Nov 9, 2018 · c9f250c · c9f250c
1 parent 731d1fa
commit c9f250c
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/lib/private/setup-dependencies/npm-link-dependency/index.js b/lib/private/setup-dependencies/npm-link-dependency/index.js
@@ -16,14 +16,17 @@ const setupExternal = async (dependencyContext, progressData) => {
 	await resolveExternalMeta(dependencyContext, progressData);
 	const {
 		latestSupportedVersion,
+		linkedPath,
 		dependencyName,
 		dependencyPath,
 		dependentName,
 		dependentPath,
 		externalMeta: { currentVersion, latestVersion },
 		versionRange
 	} = dependencyContext;
+
 	if (latestSupportedVersion !== latestVersion) {
+		// Latest version not supported, dependency installed directly (not linked)
 		if (!latestSupportedVersion) {
 			// Non semver version range, install in place
 			await rm(dependencyPath, { loose: true, recursive: true, force: true });
@@ -33,6 +36,7 @@ const setupExternal = async (dependencyContext, progressData) => {
 			});
 			return;
 		}
+
 		log.warn(
 			"%s depends on outdated %s version (%s)", dependentName, dependencyName, versionRange
 		);
@@ -48,7 +52,18 @@ const setupExternal = async (dependencyContext, progressData) => {
 		return;
 	}
 
-	if (currentVersion) return;
+	// Lastest version supported, ensure it's linked
+	if (currentVersion !== latestVersion) {
+		log.notice(
+			"external dependency %s outdated at global folder (got %s expected %s), upgrading",
+			dependencyName, currentVersion, latestVersion
+		);
+		// Global node_modules hosts outdated version, cleanup
+		await rm(linkedPath, { loose: true, recursive: true, force: true });
+	} else if (await isSymlink(dependencyPath, { linkPath: linkedPath })) {
+		return;
+	}
+
 	log.info("%s link external dependency %s", dependentName, dependencyName);
 	await rm(dependencyPath, { loose: true, recursive: true, force: true });
 	await runProgram("npm", ["link", `${ dependencyName }@${ latestVersion }`], {