feat: support recovery from any npm link error

medikoo · Oct 24, 2018 · dd453d0 · dd453d0
1 parent 9094fd5
commit dd453d0
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/lib/install-package.js b/lib/install-package.js
@@ -64,18 +64,13 @@ const linkPackage = async (packagePath, packageName) => {
 	} catch (error) {
 		log.error("npm link of %s crashed:\n%#s", packageName, error.stderr);
 		if (
-			error.code === 1 &&
-			error.stderr.includes("npm ERR! Maximum call stack size exceeded")
+			(await realpath(resolve(await getNpmModulesPath(), packageName), { loose: true })) ===
+			packagePath
 		) {
-			if (
-				(await realpath(resolve(await getNpmModulesPath(), packageName), {
-					loose: true
-				})) === packagePath
-			) {
-				log.warning("npm crashed, but as link was created we're ignoring that fact");
-				return;
-			}
+			log.warning("npm crashed but as link was created we're ignoring that fact");
+			return;
 		}
+
 		throw error;
 	}
 };