Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Envelope Name has no ikey information (MS internal) #19

Closed
XiaoliangHuang opened this issue Apr 25, 2018 · 1 comment
Closed

The Envelope Name has no ikey information (MS internal) #19

XiaoliangHuang opened this issue Apr 25, 2018 · 1 comment

Comments

@XiaoliangHuang
Copy link

issue

The Envelope Name has no ikey information, then the support from Xpert (MS UST internal tool)
e.g. the expect name is if we use ikey "AIF-37f925f3-9379-4c3d-8842-34f5e9bca1d3" (prefix "AIF-" means ApplicationInsights first party )

Microsoft.ApplicationInsights.aif37f925f393794c3d884234f5e9bca1d3.Request

but what the sdk sends out is

Microsoft.ApplicationInsights.Request

impacts

  1. Xpert will not create source node for the ikey, and then we cannot do aggregation operation, neither can we setup Dashboard or ICM Alerts

  2. This is not consistent with other AppInsights SDK like Asp.net or Java or Node.js

root cause

in the telemetry definition, the envelope name is hardcoded. e.g in the

/appinsights/contracts/requesteddata.go, the method is defined as

func (data *EventData) EnvelopeName() string {
	return "Microsoft.ApplicationInsights.Request"

the code tells that

// NOTE: This file was automatically generated.

but I cannot find source where and how the file is generated, so I cannot send a pull request to fix it.

how we use it

This is Xiaoliang from Microsoft Shagnhai team ([email protected]), exactly, we use the AilogNginx, but the root cause is the Go sdk, so I put the issue here. @jjjordanmsft we talked in Email about using it.

@jjjordanmsft
Copy link
Contributor

Thanks for the detailed bug report. Indeed the code generator lives in an internal repo on mseng. I'm OOF since my son was born but I'll have a look at this when I can get a minute.

This was referenced May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants