Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded quotes in custom attributes break the projection #1037

Closed
asklar opened this issue Nov 1, 2021 · 0 comments · Fixed by #1038
Closed

Embedded quotes in custom attributes break the projection #1037

asklar opened this issue Nov 1, 2021 · 0 comments · Fixed by #1038
Assignees
Labels
bug Something isn't working fixed Issue has been fixed in an upcoming or existing release
Milestone

Comments

@asklar
Copy link
Member

asklar commented Nov 1, 2021

Describe the bug
Follow up from #818 - quotes in a custom attribute string value will produce invalid C# code

To Reproduce
add a custom attribute like:

[doc_string("the \\\"null\\\" string.\n\n")]
class C { }

this produces the C# code:

doc_string[@"the \"null\" string.\n\n"]
class C { }

which breaks as quotes in @ strings must use double quotes

Expected behavior
double quoted strings

Version Info
1.3.0

Additional context

@asklar asklar added the bug Something isn't working label Nov 1, 2021
@manodasanW manodasanW added this to the Release 1.3.6 milestone Nov 1, 2021
@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has been fixed in an upcoming or existing release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants