Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cswinrt.sln doesn't build #692

Closed
asklar opened this issue Jan 27, 2021 · 2 comments · Fixed by #706
Closed

cswinrt.sln doesn't build #692

asklar opened this issue Jan 27, 2021 · 2 comments · Fixed by #706
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation fixed Issue has been fixed in an upcoming or existing release

Comments

@asklar
Copy link
Member

asklar commented Jan 27, 2021

Is the SLN file up to date? Looks like there are several problems, e.g. it references a BenchmarkComponent.vcxproj that doesn't exist

The WinUIDesktopSample has build errors too:

---------------------------
Microsoft Visual Studio
---------------------------
The debug executable 'C:\Users\asklar\source\repos\cswinrt\src\Samples\WinUIDesktopSample\bin\x86\Debug\net5.0-windows10.0.19041.0\WinUIDesktopSample.exe' specified in the 'WinUIDesktopSample' debug profile does not exist.
---------------------------
OK   
---------------------------

Could someone add some details in the CONTRIBUTING.md file as to how one can build this project including tests and samples? Is this supposed to be built for any cpu or x86, etc.?

@asklar asklar added the bug Something isn't working label Jan 27, 2021
@huoyaoyuan
Copy link
Contributor

You need to initialize submodules with some script. I forget the script name.

build.cmd should be updated to invoke the script.

@j0shuams
Copy link
Contributor

j0shuams commented Jan 27, 2021

Just running build uses platform x64. I agree it would be good if we had a bit more explaining how the script works, such as explaining the optional parameters. For AnyCPU, I don't think we want to support that, but you could specify Debug or Release as one of the arguments to build (seen in above link)

@angelazhangmsft angelazhangmsft self-assigned this Jan 27, 2021
@angelazhangmsft angelazhangmsft added the documentation Improvements or additions to documentation label Jan 27, 2021
@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation fixed Issue has been fixed in an upcoming or existing release
Projects
None yet
4 participants