-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the performance of invoking events #1042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manodasanW
commented
Nov 9, 2021
- Reduced the # of allocations on the event invoke code path.
- Move the custom type mapping logic in FromABI to CreateObject which allows for better caching of both the RCW for the ptr and the factory function used to create the RCW.
- Removed the use of Action via MarshalDelegateInvoke in the event invoke code path on .NET 5.
- Moved to using ThreadStatic rather than ThreadLocal for the variable which stores the RCW type as it looks to be more performant according to benchmarks.
- Avoid boxing when checking if it is a reference to a managed object and also avoid the need to create a IObjectReference to do so.
- Reduce the # of IObjectReferences created by creating a specialized version of CreateCCW which gives you the ObjectReference with the right vftbl and does a QI.
- Added a set of benchmarks that helped evaluate the improvements
Scottj1s
reviewed
Nov 9, 2021
Scottj1s
reviewed
Nov 9, 2021
Scottj1s
reviewed
Nov 9, 2021
Scottj1s
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.