Don't use exceptions for flow control when loading dlls. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaanstra
force-pushed
the
user/jlaans/no-dll-load-exceptions
branch
from
a314389 to
a17b6e1
Compare
|
Internal bug for this: 34604102 |
manodasanW
reviewed
Jul 27, 2021
|
Can you locally run build.cmd and confirm everything builds fine and all the tests it runs pass? |
|
@manodasanW Build completed locally. Some test didn't run because it couldn't find a test adapter, but the tests that did run passed. Probably wanna do a CI build or a local build to also validate yourself. |
manodasanW
reviewed
Jul 28, 2021
manodasanW
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way CsWinRT loads dlls to use the Try* pattern. Currently lookup throws an exception when a specific dll is not found resulting in a lot of first chance exceptions being thrown slowing down debugging.