Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxford Triton driver: only add magnet parameters if one is present #6792

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

thangleiter
Copy link
Contributor

This patch tests if the Triton can communicate with the magnet. If not, parameters pertaining to the magnet are not added to the instrument. This avoids complications when snapshotting the instrument for instance.

Reasons for communication failure are

  1. no magnet is equipped to begin with.
  2. the magnet power supply (Mercury iPS) is set up for a different communication protocol (TCP/IP for example).

@thangleiter thangleiter requested a review from a team as a code owner January 14, 2025 14:37
@thangleiter thangleiter changed the title Only add magnet parameters if one is present Oxford Triton driver: only add magnet parameters if one is present Jan 14, 2025
@jenshnielsen
Copy link
Collaborator

thanks @thangleiter Looks fine, Note that this driver is not particularly well maintained. There is also a driver in https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/main/src/qcodes_contrib_drivers/drivers/OxfordInstruments/Triton.py which may be of interest.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 69.37%. Comparing base (7b3b63a) to head (67cef17).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/instrument_drivers/oxford/triton.py 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6792      +/-   ##
==========================================
- Coverage   69.39%   69.37%   -0.02%     
==========================================
  Files         340      340              
  Lines       31335    31341       +6     
==========================================
  Hits        21744    21744              
- Misses       9591     9597       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue Jan 16, 2025
Merged via the queue into microsoft:main with commit 74a3a8d Jan 16, 2025
16 of 18 checks passed
@thangleiter
Copy link
Contributor Author

thanks @thangleiter Looks fine, Note that this driver is not particularly well maintained. There is also a driver in https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/main/src/qcodes_contrib_drivers/drivers/OxfordInstruments/Triton.py which may be of interest.

Thanks, unfortunately that driver is basically just an offline log file parser and does not interact with the fridge at all.

@thangleiter thangleiter deleted the enh/oxford_triton_without_magnet branch January 16, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants