Rename request on import path returns incorrect locs

[mjbvz]

TypeScript Version: 3.2.0-dev.20180926

Search Terms:

• rename
• tsserver

Code

1. For a TS project:

a.ts

import {} from './sub/b'

sub/b.ts:

export const abc =123;

2. Trigger a rename on the filename b in a.ts

Expected behavior:
Returned locs should only include the file name segment of the path in a.ts

Actual behavior:
Returned locs include the entire import path in a.ts

[Trace  - 2:02:28 PM] Response received: rename (180). Request took 2 ms. Success: true 
Result: {
    "info": {
        "canRename": true,
        "fileToRename": "/Users/matb/projects/san/sub/b.ts",
        "displayName": "/Users/matb/projects/san/sub/b.ts",
        "fullDisplayName": "/Users/matb/projects/san/sub/b.ts",
        "kind": "module",
        "kindModifiers": "",
        "triggerSpan": {
            "start": {
                "line": 1,
                "offset": 24
            },
            "end": {
                "line": 1,
                "offset": 25
            }
        }
    },
    "locs": [
        {
            "file": "/Users/matb/projects/san/a.ts",
            "locs": [
                {
                    "start": {
                        "line": 1,
                        "offset": 18
                    },
                    "end": {
                        "line": 1,
                        "offset": 25
                    }
                }
            ]
        }
    ]
}

[ghost]

If fileToRename is set you should use that instead of locs. triggerSpan tells you the span at the original location.

[mjbvz]

Yes you are correct. I was using the api incorrectly but have fixed this on the VS code side

Sorry for the noise