-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: handle absent crypto, fixes #19100 #19101
Conversation
Fix for Handle absent crypto as per nodejs docs
I am assuming we dont want to make it optional in tsserver. |
@sheetalkamat do you think it's a good idea to allow running tsserver without crypto too? |
We have too many assumptions that if |
@mhegazy let's calculate a weak hash in code |
sure |
@mhegazy just to check: collisions due to weak hash are only affecting performance, cannot cause incorrect behaviour, is that right? |
that is my expectation as well. |
closing for now. please reopen with a default implementation for a weak hash function. |
Fixes #19100