Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle absent crypto, fixes #19100 #19101

Closed
wants to merge 4 commits into from
Closed

Fix: handle absent crypto, fixes #19100 #19101

wants to merge 4 commits into from

Conversation

mihailik
Copy link
Contributor

Fixes #19100

@sheetalkamat
Copy link
Member

I am assuming we dont want to make it optional in tsserver.
(checkout https://github.com/Microsoft/TypeScript/blob/master/src/server/editorServices.ts#L408)

@mihailik
Copy link
Contributor Author

@sheetalkamat do you think it's a good idea to allow running tsserver without crypto too?

@mhegazy
Copy link
Contributor

mhegazy commented Oct 16, 2017

We have too many assumptions that if --watch is allowed we can use hashes. just checking here is not sufficient i am afraid.

@mihailik
Copy link
Contributor Author

@mhegazy let's calculate a weak hash in code

@mhegazy
Copy link
Contributor

mhegazy commented Oct 16, 2017

sure

@mihailik
Copy link
Contributor Author

@mhegazy just to check: collisions due to weak hash are only affecting performance, cannot cause incorrect behaviour, is that right?

@mhegazy
Copy link
Contributor

mhegazy commented Oct 16, 2017

that is my expectation as well.

@mhegazy
Copy link
Contributor

mhegazy commented Nov 9, 2017

closing for now. please reopen with a default implementation for a weak hash function.

@mhegazy mhegazy closed this Nov 9, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants