Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split button isn't getting activated with caps+enter. #164

Closed
2 of 12 tasks
YuliKl opened this issue Aug 27, 2019 · 4 comments
Closed
2 of 12 tasks

Split button isn't getting activated with caps+enter. #164

YuliKl opened this issue Aug 27, 2019 · 4 comments
Labels
accessibility Issues related to accessibility bug Something isn't working

Comments

@YuliKl
Copy link

YuliKl commented Aug 27, 2019

Describe the bug

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Launch XAML Controls Gallery.
  2. Activate Split button from All controls page.
  3. Navigate to "Font color" split button present in the page and press caps+enter to activate it.

Expected behavior

The primary activation command with the narrator to activate a button is caps+enter. Hence a split button should get activated with caps+enter.

Actual behavior

The split button isn't getting activated with caps+enter.

Screenshots

image

Observation: Toggle split button gets activated with caps+enter successfully.

User Impact: Visually impaired users will be affected as a basic command to activate split button isn't working

Version Info

Gallery version (found on Settings page):

App Version: 1.2.9.0

Windows 10 version:

  • Insider Build (xxxxx)
  • May 2019 Update (18362)
  • October 2018 Update (17763)
  • April 2018 Update (17134)
  • Fall Creators Update (16299)
  • Creators Update (15063)
  • Anniversary Update (14393)

Device form factor:

  • Desktop
  • Mobile
  • Xbox
  • Surface Hub
  • IoT

Additional context

Copied from internal bug

@YuliKl YuliKl added bug Something isn't working accessibility Issues related to accessibility labels Aug 27, 2019
@marcelwgn
Copy link
Contributor

marcelwgn commented Aug 29, 2019

Using narrator, hitting caps+enter does trigger the click method of the button.

However there seems to be now way to open the flyout of a (Toggle)SplitButton using keyboard shortcuts (at least not without adding one). Thanks to @jevansaks for the clarification.
I think this is a spec-issue as there also is an issue over at WinUI regarding the buttons behaviour with touch.

Update: There is an issue over at WinUI addressing the tabbing behavior of the SplitButton.

@marcelwgn
Copy link
Contributor

Upon further investigation, I noticed that the SplitButton does trigger the correct events, the "Clicked" effect is just not visually present.

I noticed that the SplitButton is not really intuitive to use (user has to select text before pressing the button makes a difference).
@YuliKl Should we modify the example to be a bit more intuitive to use?

@YuliKl
Copy link
Author

YuliKl commented Aug 29, 2019

While I'm definitely open to ideas about how to change this sample, this may just be a bug that we need to resolve as "Won't Fix".

@YuliKl
Copy link
Author

YuliKl commented Sep 3, 2019

Closing as I don't think we have any ideas for how to correct this problem.

@YuliKl YuliKl closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants