Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a MainWindow + new titlebar #1736

Open
niels9001 opened this issue Jan 29, 2025 · 2 comments
Open

Create a MainWindow + new titlebar #1736

niels9001 opened this issue Jan 29, 2025 · 2 comments
Assignees
@niels9001
Labels
app enhancement Requests for general app improvements

Comments

@niels9001
Copy link
Contributor

niels9001 commented Jan 29, 2025 •
edited
Loading

We currently create a new Window upon launch, and settings the NavigationRootPage as its content.

Creating a MainWindow and moving that code there makes things easier when we want to make use of certain Windowing APIs and the new TitleBar.

Once the new TitleBar control is in stable, we can move the NavigationView-button and searchbox to the titlebar area per latest design guidance:

Image
@niels9001 niels9001 self-assigned this Jan 29, 2025
@niels9001 niels9001 added app enhancement Requests for general app improvements and removed needs-triage labels Jan 29, 2025
@niels9001 niels9001 changed the title Create a MainWindow.xaml Create a MainWindow + new titlebar Feb 12, 2025
@Jay-o-Way
Copy link
Contributor

Must solve #1605

@Jay-o-Way
Copy link
Contributor

Also note (for example) #145 which seems to be a work-around that probably should be reverted. If you create the MainWindow with the Navigation from scratch, you should find this. FYI @marcelwgn right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niels9001 niels9001

Labels
app enhancement Requests for general app improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niels9001 @Jay-o-Way