Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ControlInfoDataSchema #1784

Open
Zakariathr22 opened this issue Feb 21, 2025 · 4 comments
Open

Optimize ControlInfoDataSchema #1784

Zakariathr22 opened this issue Feb 21, 2025 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@Zakariathr22
Copy link
Contributor

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

Many properties in ControlInfoDataSchema are no longer used in the JSON, while others, despite being present in the JSON, are not displayed in the app (e.g., RelatedControls).

To improve maintainability and clarity, I suggest minimizing ControlInfoDataSchema by removing properties that are no longer used and reviewing properties that exist in the JSON but are not displayed, ensuring they are either utilized or removed if unnecessary.

Screenshots

No response

Windows version

No response

Additional context

No response

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Feb 22, 2025

Sounds good. There's also the larger issue that the actual file name (just like ControlInfoData.json) is still centered on Controls, but the app is no longer "Xaml Controls Gallery" - it's WinUI Gallery with more/different aspects...

@Zakariathr22
Copy link
Contributor Author

Sounds good. There's also the larger issue that the actual file name (just like ControlInfoData.json) is still centered on Controls, but the app is no longer "Xaml Controls Gallery" - it's WinUI Gallery with more/different aspects...

Acttually, the name Controls isn't entirely accurate. Perhaps renaming the files and folders as follows would be more appropriate?

Current Name Suggested Name
ControlImages SampleImages
ControlInfoData... SampleInfoData...
Samples\ControlPages Samples\Pages

@Jay-o-Way
Copy link
Contributor

Acttually, the name Controls isn't entirely accurate. Perhaps renaming the files and folders as follows would be more appropriate?

That's what I mean. But this is moving into issue #1744, which is much larger.

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Feb 23, 2025

P.S. version draft-04 is from 2013

The latest version of JSON Schema is 2020-12, which represents the latest advancements and has expanded capabilities compared with the previous versions, draft-04, draft-06, and draft-07.

We recommend using the newest version of JSON Schema and taking advantage of its benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants