Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WIL. Update C++/WinRT. Tweak build order #2586

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

DrusTheAxe
Copy link
Member

Updated WIL references to 1.0.220201.1 (latest)

Updated CppWinRT references to 2.0. (latest)

Tweaked a few projects' BuildOrder to avoid build errors due to out-of-order compilation (can't build Foo dependent on Bar before building Bar. At least, not reliably, across a variety of hardware)

@DrusTheAxe DrusTheAxe added the area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) label Jun 7, 2022
@DrusTheAxe DrusTheAxe added this to the 1.2 milestone Jun 7, 2022
@DrusTheAxe DrusTheAxe self-assigned this Jun 7, 2022
@ghost ghost added the needs-triage label Jun 7, 2022
@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jonwis jonwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be nice if there was a bot that could do this. Thanks for figuring out the build order, though, that's been annoying. :)

@DrusTheAxe DrusTheAxe merged commit 5385ff2 into main Jun 8, 2022
@DrusTheAxe DrusTheAxe deleted the user/drustheaxe/dependencies-wil branch June 8, 2022 06:01
@DrusTheAxe
Copy link
Member Author

DrusTheAxe commented Jun 8, 2022

Be nice if there was a bot that could do this. Thanks for figuring out the build order, though, that's been annoying. :)

Maestro updates ~half the build dependencies. The other half are currently Maestro-oblivious and static decentralized artifacts.

I'm working on a script that'll report and/or fixup versions based on a central MasterSourceOfAllTruth(TM) file. When we decide to update a dependency the process will be "update version in text file" for Maestro or "update version in text file and run 1-liner command" for non-Maestro-managed dependencies.

I'd like to see the nightly produce a report of any inconsistencies and eventually make it part of the PR build process, error on any inconsistencies so developers adding or updating projects would have to run the script locally to sync their new bits to the standard tooling before checkin.

One step at a time :-)

The goal is to make this the last time I (or anyone else) hand edits these things. I'm fiddling between other higher priority tasks so slow but steady progress. Watch this space....

@kythant kythant mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) needs-triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants