Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NuGetToolInstallerV0 task to Node10 #15822

Conversation

mr-dokara
Copy link
Contributor

Task name: NuGetToolInstallerV0

Description: Migrated task to Node10

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped
  • Checked that applied changes work as expected

@mr-dokara mr-dokara requested a review from a team January 25, 2022 12:25
@mr-dokara
Copy link
Contributor Author

cc @geekzter for visibility

@mr-dokara mr-dokara requested a review from mmrazik February 25, 2022 09:06
@mr-dokara
Copy link
Contributor Author

Hi @aasim, @phil-hodgson, Could you please take a look at this PR?

@mr-dokara mr-dokara requested a review from satbai as a code owner June 30, 2022 15:27
@DmitriiBobreshev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@DmitriiBobreshev
Copy link
Contributor

DmitriiBobreshev commented Jun 30, 2022

Test results are here

Risks analysis checklist

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • We understand how tasks are working, how changes affect task behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases

@DmitriiBobreshev
Copy link
Contributor

DmitriiBobreshev commented Jul 6, 2022

Hi @phil-hodgson, @aasim, @satbai Could you please take a look at this PR?

@mpodriezov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tintse-thxsky-MSFT
Copy link
Contributor

make sure the
azure-pipelines-tasks.ci-linux
azure-pipelines-tasks.ci-macos
azure-pipelines-tasks.ci-windows
passes.

@mpodriezov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tintse-thxsky-MSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tintse-thxsky-MSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tintse-thxsky-MSFT tintse-thxsky-MSFT merged commit ab671f0 into master Jul 28, 2022
@tintse-thxsky-MSFT tintse-thxsky-MSFT deleted the users/golubev-ivan/migrate-nuget-tool-installer-v0-to-node10 branch July 28, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants