-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TwineAuthenticateV0-1 to Node 10 #15924
Migrate TwineAuthenticateV0-1 to Node 10 #15924
Conversation
Tested with pipeline for canary builds |
@AndreyIvanov42 please check failed tests - can we fix it quickly or it would require some investigation of how task works? |
https://github.com/AndreyIvanov42/azure-pipelines-tasks into users/v-andivanov/migrate-twine-authenticateV0-node10
@anatolybolshakov Some investigation is need |
https://github.com/AndreyIvanov42/azure-pipelines-tasks into users/v-andivanov/migrate-twine-authenticateV0-node10
@anatolybolshakov |
…-tasks into users/v-andivanov/migrate-twine-authenticateV0-node10
f39acd6
to
06c71ba
Compare
@phil-hodgson @aasim @satbai Could you please review and approve the PR if all is fine? |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Test results are here Risks analysis checklist
|
Tasks/TwineAuthenticateV1/task.json
Outdated
@@ -9,14 +9,14 @@ | |||
"category": "Package", | |||
"version": { | |||
"Major": 1, | |||
"Minor": 198, | |||
"Minor": 201, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be 207
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 208 even at this moment
Hi @phil-hodgson, @aasim, @satbai Could you please take a look at this PR? |
Task name: TwineAuthenticateV0-1
Description: migrate task to Node 10
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Checklist: