Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate DownloadGitHubReleaseV0 to node10 execution #16736

Merged
merged 16 commits into from
Aug 18, 2022
Merged

Migrate DownloadGitHubReleaseV0 to node10 execution #16736

merged 16 commits into from
Aug 18, 2022

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Aug 15, 2022 •
edited
Loading

Task name: DownloadGitHubReleaseV0

Description: This PR migrates DownloadGitHubReleaseV0 to node10 execution. Also some other changes provided - check changelog.

Changelog:

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) #16250

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - unit tests & manual run. Works fine

@KonstantinTyukalov KonstantinTyukalov mentioned this pull request Aug 15, 2022
Closed
max-zaytsev
max-zaytsev reviewed Aug 15, 2022
View reviewed changes
Copy link

@max-zaytsev max-zaytsev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix minimumAgentVersion according to our guide
"minimumAgentVersion": "2.144.0",

@KonstantinTyukalov
Copy link
Contributor Author

We need to fix minimumAgentVersion according to our guide "minimumAgentVersion": "2.144.0",

Fixed, thanks!

@v-nmursapall
Copy link
Contributor

Please give me 2-3 days time, working on other priority items for now.

v-nmursapall
v-nmursapall approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@v-nmursapall v-nmursapall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine, approving.

@KonstantinTyukalov KonstantinTyukalov merged commit 2b04706 into master Aug 18, 2022
@KonstantinTyukalov KonstantinTyukalov deleted the users/KonstantinTyukalov/DownloadGitHubReleaseV0_node_10 branch April 16, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmrazik mmrazik mmrazik approved these changes

@max-zaytsev max-zaytsev max-zaytsev approved these changes

@vmapetr vmapetr vmapetr approved these changes

@v-nmursapall v-nmursapall v-nmursapall approved these changes

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

Assignees
No one assigned
Labels
node-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KonstantinTyukalov @v-nmursapall @mmrazik @max-zaytsev @vmapetr @kirill-ivlev