Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Remove unneeded helper methods from Activity #823

Closed
tracyboehrer opened this issue Oct 20, 2020 · 0 comments · Fixed by #834
Closed

Remove unneeded helper methods from Activity #823

tracyboehrer opened this issue Oct 20, 2020 · 0 comments · Fixed by #834
Assignees
@LeeParrishMSFT
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) Size: S The issue is simple and well understood, it will take a day or less to complete technical-debt Refactoring, follow best practices, improve test coverage, etc.
Milestone
R12

Comments

@tracyboehrer
Copy link
Member

Method like: asMessageDeleteActivity, asSuggestionActivity, and the others that start with "as" aren't used except in tests. This is a holder-over from the C# port where Activity implements a number of different interfaces.

Remove these methods and the associated unit tests.
@tracyboehrer tracyboehrer added technical-debt Refactoring, follow best practices, improve test coverage, etc. Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) labels Oct 20, 2020
@tracyboehrer tracyboehrer added this to the R12 milestone Oct 23, 2020
@tracyboehrer tracyboehrer added the Size: S The issue is simple and well understood, it will take a day or less to complete label Oct 23, 2020
@LeeParrishMSFT LeeParrishMSFT mentioned this issue Oct 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LeeParrishMSFT LeeParrishMSFT

Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) Size: S The issue is simple and well understood, it will take a day or less to complete technical-debt Refactoring, follow best practices, improve test coverage, etc.
Projects
None yet
Milestone
R12
Development

Successfully merging a pull request may close this issue.

Removed unused "as" methods. microsoft/botbuilder-java
2 participants
@tracyboehrer @LeeParrishMSFT