Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent ConversationParameters interface #4859

Open
Wadu436 opened this issue Feb 13, 2025 · 0 comments
Open

Inconsistent ConversationParameters interface #4859

Wadu436 opened this issue Feb 13, 2025 · 0 comments
Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@Wadu436
Copy link

Wadu436 commented Feb 13, 2025

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Versions

  • What package version of the SDK are you using.
    [email protected]

  • What nodejs version are you using
    N/A but Node 22

  • What browser version are you using
    N/A but Chrome

  • What os are you using
    N/A but MacOS 15.3

Describe the bug

There's an inconsistency between the docstring and the actual type for the activity field in the ConversationParameters interface. The docstring claims it is optional, but according to the type it is required.

To Reproduce

Steps to reproduce the behavior:

  1. Go to index.ts:872-876 file in the botframework-schema
  2. Look at the docstring for the activity field
  3. Look at the type for the activity field

Expected behavior

For the docstring and the interface to be consistent.

@Wadu436 Wadu436 added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

No branches or pull requests

1 participant