fix(Button): renderIcon prop (#347)

microsoft · Oct 10, 2018 · 3421c5e · 3421c5e
1 parent 9d9ab58
commit 3421c5e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## [Unreleased]
 
+### Fixes
+- Fix Button's `renderIcon` prop @levithomason ([#347](https://github.com/stardust-ui/react/pull/347))
+
 ### Features
 - Make `content` to be a shorthand prop for `Popup` @kuzhelov ([#322](https://github.com/stardust-ui/react/pull/322))
 - Add generic `Slot` component (used internally) and use it as shorthand for `Button` `content` prop @Bugaa92 ([#335](https://github.com/stardust-ui/react/pull/335))

diff --git a/src/components/Button/Button.tsx b/src/components/Button/Button.tsx
@@ -177,8 +177,8 @@ class Button extends UIComponent<Extendable<IButtonProps>, IButtonState> {
         styles: styles.icon,
         xSpacing: !content ? 'none' : iconPosition === 'after' ? 'before' : 'after',
         variables: variables.icon,
-        render: renderIcon,
       },
+      render: renderIcon,
     })
   }