fix(doc): Use correct LTR/RTL Fela renderer in renderComponent (#34)

* fix(doc): Use correct LTR/RTL Fela renderer in renderComponent

fixes #24

CHANGELOG.md

@@ -28,6 +28,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ### Documentation
 - Improve UX for "knobs" form on component examples @levithomason ([#20](https://github.com/stardust-ui/react/pull/20))
+- Use correct styles in RTL component preview @miroslavstastny ([#34](https://github.com/stardust-ui/react/pull/34))
 
 <!--------------------------------[ v0.2.3 ]------------------------------- -->
 ## [v0.2.3](https://github.com/stardust-ui/react/tree/v0.2.3) (2018-07-24)

src/components/Provider/Provider.tsx

@@ -36,22 +36,27 @@ class Provider extends Component<any, any> {
 
   static Consumer = ProviderConsumer
 
-  renderStaticStyles = felaRenderer => {
+  renderStaticStyles = () => {
+    // RTL WARNING
+    // This function sets static styles which are global and renderer agnostic
+    // With current implementation, static styles cannot differ between LTR and RTL
+    // @see http://fela.js.org/docs/advanced/StaticStyle.html for details
+
     const { siteVariables, staticStyles } = this.props
 
     if (!staticStyles) return
 
     const renderObject = object => {
       _.forEach(object, (style, selector) => {
-        felaRenderer.renderStatic(style, selector)
+        felaLtrRenderer.renderStatic(style, selector)
       })
     }
 
     const staticStylesArr = [].concat(staticStyles)
 
     staticStylesArr.forEach(staticStyle => {
       if (_.isString(staticStyle)) {
-        felaRenderer.renderStatic(staticStyle)
+        felaLtrRenderer.renderStatic(staticStyle)
       } else if (_.isPlainObject(staticStyle)) {
         renderObject(staticStyle)
       } else if (_.isFunction(staticStyle)) {
@@ -64,7 +69,12 @@ class Provider extends Component<any, any> {
     })
   }
 
-  renderFontFaces = felaRenderer => {
+  renderFontFaces = () => {
+    // RTL WARNING
+    // This function sets static styles which are global and renderer agnostic
+    // With current implementation, static styles cannot differ between LTR and RTL
+    // @see http://fela.js.org/docs/advanced/StaticStyle.html for details
+
     const { siteVariables, fontFaces } = this.props
 
     if (!fontFaces) return
@@ -73,7 +83,7 @@ class Provider extends Component<any, any> {
       if (!_.isPlainObject(font)) {
         throw new Error(`fontFaces must be objects, got: ${typeof font}`)
       }
-      felaRenderer.renderFont(font.name, font.path, font.style)
+      felaLtrRenderer.renderFont(font.name, font.path, font.style)
     }
 
     const fontFaceArr = [].concat(_.isFunction(fontFaces) ? fontFaces(siteVariables) : fontFaces)
@@ -84,17 +94,21 @@ class Provider extends Component<any, any> {
   }
 
   componentDidMount() {
-    const felaRenderer = this.props.rtl ? felaRtlRenderer : felaLtrRenderer
-    this.renderStaticStyles(felaRenderer)
-    this.renderFontFaces(felaRenderer)
+    this.renderStaticStyles()
+    this.renderFontFaces()
   }
 
   render() {
     const { componentVariables, siteVariables, children, rtl } = this.props
+    const renderer = rtl ? felaRtlRenderer : felaLtrRenderer
 
     // ensure we don't assign `undefined` values to the theme context
     // they will override values down stream
-    const theme: any = { rtl: !!rtl }
+    const theme: any = {
+      renderer,
+      rtl: !!rtl,
+    }
+
     if (siteVariables) {
       theme.siteVariables = siteVariables
     }
@@ -103,7 +117,7 @@ class Provider extends Component<any, any> {
     }
 
     return (
-      <RendererProvider renderer={this.props.rtl ? felaRtlRenderer : felaLtrRenderer}>
+      <RendererProvider renderer={renderer}>
         <ThemeProvider theme={theme}>{children}</ThemeProvider>
       </RendererProvider>
     )

src/lib/getClasses.tsx

@@ -1,5 +1,3 @@
-import renderer from './felaRenderer'
-
 export interface IClasses {
   [key: string]: string
 }
@@ -11,7 +9,13 @@ export interface IClasses {
  * @param theme
  * @returns {{}}
  */
-const getClasses = (props, rules, variables: any = () => {}, theme: any = {}): IClasses => {
+const getClasses = (
+  renderer,
+  props,
+  rules,
+  variables: any = () => {},
+  theme: any = {},
+): IClasses => {
   const { renderRule } = renderer
   const ruleProps = {
     props,

src/lib/renderComponent.tsx

@@ -34,7 +34,7 @@ const renderComponent = <P extends {}>(
   return (
     <FelaTheme
       render={theme => {
-        const { siteVariables = {}, componentVariables = {} } = theme
+        const { siteVariables = {}, componentVariables = {}, renderer } = theme
 
         const ElementType = getElementType({ defaultProps }, props)
         const rest = getUnhandledProps({ handledProps }, props)
@@ -45,7 +45,7 @@ const renderComponent = <P extends {}>(
         const mergedVariables = () =>
           Object.assign({}, variablesFromFile, variablesFromTheme, variablesFromProp)
 
-        const classes = getClasses(props, rules, mergedVariables, theme)
+        const classes = getClasses(renderer, props, rules, mergedVariables, theme)
         classes.root = cx(className, classes.root, props.className)
 
         const config: IRenderResultConfig<P> = { ElementType, rest, classes }

test/specs/commonTests/isConformant.tsx

@@ -1,12 +1,21 @@
 import _ from 'lodash'
 import React from 'react'
-import { shallow, mount, render } from 'enzyme'
+import { shallow, mount as enzymeMount, render } from 'enzyme'
 import ReactDOMServer from 'react-dom/server'
+import { ThemeProvider } from 'react-fela'
 
 import { assertBodyContains, consoleUtil, syntheticEvent } from 'test/utils'
 import helpers from './commonHelpers'
 
 import * as stardust from 'src/'
+import { felaRenderer } from 'src/lib'
+
+const mount = (node, options?) => {
+  return enzymeMount(
+    <ThemeProvider theme={{ renderer: felaRenderer }}>{node}</ThemeProvider>,
+    options,
+  )
+}
 
 /**
  * Assert Component conforms to guidelines that are applicable to all components.
@@ -24,7 +33,10 @@ export default (Component, options: any = {}) => {
 
   // This is added because of the FelaTheme wrapper and the component itself, because it is mounted
   const getComponent = wrapper => {
-    return wrapper.childAt(0).childAt(0)
+    return wrapper
+      .childAt(0)
+      .childAt(0)
+      .childAt(0)
   }
 
   // make sure components are properly exported
@@ -260,7 +272,7 @@ export default (Component, options: any = {}) => {
           'data-simulate-event-here': true,
         }
 
-        const component = mount(<Component {...props} />)
+        const component = mount(<Component {...props} />).childAt(0)
 
         const eventTarget = eventTargets[listenerName]
           ? component