Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

chore(AutoControlledComponent): use getDerivedStateFromProps instead of componentWillReceiveProps #1305

Merged
merged 2 commits into from
May 9, 2019

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented May 9, 2019

Needed for #1270

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #1305 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1305   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         747      747           
  Lines        5654     5654           
  Branches     1633     1632    -1     
=======================================
  Hits         4118     4118           
  Misses       1529     1529           
  Partials        7        7
Impacted Files Coverage Δ
packages/react/src/lib/AutoControlledComponent.tsx 91.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00ac2c...2865ebc. Read the comment docs.

@silviuaavram silviuaavram merged commit 6f08626 into master May 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore-refactor-autocontrolledcomponent branch May 9, 2019 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants