This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(Chat): Add expandable control messages prototype #1765
feat(Chat): Add expandable control messages prototype #1765
Changes from 11 commits
22b4c34
0723365
ddcd634
630e0fc
9221e8f
4bcb8f5
2374e2f
9611340
31ddef1
90f5435
e819f10
c1d44bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's follow the convention for the other stardust component's classNames. It should be something like
ui-chat__message_control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change for the prototyping or a real fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's additional safety thing. Helps both for prototype and overall behavior. Chat Message should be always focusable, meaning - to have set
tabIndex=-1
. When component re-renders based on state change,FocusZone
won't pick this change up unless you move arrow keys, so the chat message will be rendered without tabIndex - thus not focusable