Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(emptyTheme): avoid theme object mutation #1846

Closed
wants to merge 1 commit into from

Conversation

layershifter
Copy link
Member

Fixes a small regression from #1837 that was mentioned by @levithomason.

???

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #1846 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1846      +/-   ##
==========================================
- Coverage   69.64%   69.63%   -0.01%     
==========================================
  Files         874      875       +1     
  Lines        7612     7611       -1     
  Branches     2216     2216              
==========================================
- Hits         5301     5300       -1     
  Misses       2303     2303              
  Partials        8        8
Impacted Files Coverage Δ
packages/react/src/lib/renderComponent.tsx 84.74% <100%> (ø) ⬆️
packages/react/src/lib/createEmptyTheme.ts 100% <100%> (ø)
packages/react/src/lib/mergeThemes.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84be797...e858eaf. Read the comment docs.

@lucivpav
Copy link
Contributor

How about testing this fix?

@jdhuntington
Copy link
Contributor

Closing as this has seen no activity for awhile. Please reopen if still relevant. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants