This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(Chat): fix handling of `onMouseEnter` * add changelog entry * Update packages/react/src/components/Chat/ChatMessage.tsx Co-Authored-By: Pavel Lučivňák <[email protected]> (cherry picked from commit 2eeb285)
* docs: remove HTML, improve error readout * docs: add changelog entry (cherry picked from commit 18f35b0)
* first implementation * shorthand on slots * fix the click handlers * addressed comments from PR * prevent default behavior * address code review with ref * moved it as a separate example * changed the example content * replaced specification of behaviour * address more code review * add behavior in tests * moved behavior * add styles * focus button on select * some minor improvements * updated styles * keep the Tab key handler * refactored buttons * updates on styles and toggle close * addressed code review * fix behavior test * made component conformant * defaultProp toggleButton * changelog * add more unit tests * add more tests * fix focus style on toggle button * more examples * changed the padding according to specs * code review integration * use focus-visible in styles * revert style slot rename * add best practices * fix variable name * update changelog * call onOpenChange with this.props * change onOpenChange prop type * changelog update * integrate code review (cherry picked from commit e7a59c0)
* accessibility for horizontal list * better prop types, add steps test * changelog * fix steps test (cherry picked from commit 7ca52d9)
* fix focus styles * add static Item to Tree * add screener tests for focus * fix selector * fix the selector better * removed unnecessary static item * change selector in screener tests * move all into a single test * change the test to allow all kb interactions * revert unneeded change * changelog (cherry picked from commit 2a9989e)
* add react-virtualized to package and yarn lock * add virtualized render prop to Tree * add virtualized tree in prototypes * add alternative solution in comments * add back as any from merging master * have refs for all items * fix the cloneElement approach * fix ref issue * increase virtualized tree size * rename the render prop * add changelog * fix use of prop name * move items code from prototype * address code review * make prototype public Co-Authored-By: Oleksandr Fediashov <[email protected]> * use lodash times function (cherry picked from commit 6935b97)
* docs(Knobs): improve LogInspector * fix spacing * Update packages/code-sandbox/src/callbackLogFormatter.ts Co-Authored-By: Marija Najdova <[email protected]> * update signatures, add description * revert example * fix example (cherry picked from commit 06d3814)
) * fix(Chat): use more accurate positioning in scrollable containers * add example * add changelog (cherry picked from commit 98b8229)
Codecov Report
@@ Coverage Diff @@
## master #1932 +/- ##
==========================================
- Coverage 70.47% 70.12% -0.35%
==========================================
Files 884 895 +11
Lines 7796 7854 +58
Branches 2280 2263 -17
==========================================
+ Hits 5494 5508 +14
- Misses 2291 2335 +44
Partials 11 11
Continue to review full report at Codecov.
|
Changed dependencies are detected.Changed dependencies in
Changed dependencies are detected.Changed dependencies in
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
onMouseEnter
prop inChatMessage
@layershifter (fix(Chat): fix handling ofonMouseEnter
#1903)TreeItem
andHierarchicalTreeItem
@silviuavram (#1912)actions
inChat.Message
when is inside scrollable containers @layershifter (#1929)Features
navigable
List
variant @jurokapsiar (#1904)SplitButton
component @silviuavram (#1789)Documentation
VirtualizedTree
prototype @silviuavram (#1890)