This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusZone): Fixing a core keydown disconnect issue #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzearing
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
jurokapsiar
approved these changes
Oct 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have multiple outer zones on the page, the first one hooks up a global keydown handler to manage tab presses. This is only hooked up on the first outer zone instance.
When that instance is unmounted, the event handler goes away. In normal cases, first in last out would never hit a bug. But when you have first in first out scenarios, you are left with focuszones on the page that dont get tabindex fixes on hitting tab.
This fix makes sure that the global event handler is only disconnected on the last outer zone unmount.