Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

[tooling] renaming all instances of @stardust-ui to @fluentui #2117

Merged
merged 11 commits into from
Nov 20, 2019

Conversation

kenotron
Copy link
Member

This is part of a multi-step change to converge the future of Fabric and Stardust UI libraries into Fluent UI. Some of this work may not be complete until I have a PR triggered build - so I'm going to keep this open until I get a chance to see what jobs are busted before fixing it up.

What does this include?

  • All instances of @stardust-ui has been renamed to @FluentUI
  • import statements are changed appropriately in src and test code

What does it NOT include?

  • non-import statement code changes

What will (should be made to...) work

  • innerloop
  • CI builds
  • test:projects
  • docs
  • e2e

What will NOT work?

  • things should all be working as before except for some URL changes for things like circle-ci jobs, screener jobs, etc.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Nov 16, 2019

Warnings
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies are detected.

Changed dependencies in packages/code-sandbox/package.json

package before after
@fluentui/react - ^0.40.3

Changed dependencies are detected.

Changed dependencies in packages/internal-tooling/package.json

package before after
@fluentui/eslint-plugin - ^0.40.0

Changed dependencies are detected.

Changed dependencies in packages/react/package.json

package before after
@fluentui/accessibility - ^0.40.2
@fluentui/react-bindings - ^0.40.2
@fluentui/react-component-event-listener - ^0.40.0
@fluentui/react-component-nesting-registry - ^0.40.0
@fluentui/react-component-ref - ^0.40.0
@fluentui/react-proptypes - ^0.40.0

Changed dependencies are detected.

Changed dependencies in packages/react-bindings/package.json

package before after
@fluentui/accessibility - ^0.40.2
@fluentui/state - ^0.40.0

Generated by 🚫 dangerJS

@kenotron
Copy link
Member Author

Looks like Danger is reporting this:

Failures

All of your entries in CHANGELOG.md should be in the Unreleased section!

Warnings

Package (or peer) dependencies changed. Make sure you have approval before merging!

Markdowns

Changed dependencies are detected.

Changed dependencies in packages/internal-tooling/package.json

package before after
@fluentui/eslint-plugin - ^0.40.0

Changed dependencies are detected.

Changed dependencies in packages/react-bindings/package.json

package before after
@fluentui/accessibility - ^0.40.2
@fluentui/state - ^0.40.0

Changed dependencies are detected.

Changed dependencies in packages/code-sandbox/package.json

package before after
@fluentui/react - ^0.40.3

Changed dependencies are detected.

Changed dependencies in packages/react/package.json

package before after
@fluentui/accessibility - ^0.40.2
@fluentui/react-bindings - ^0.40.2
@fluentui/react-component-event-listener - ^0.40.0
@fluentui/react-component-nesting-registry - ^0.40.0
@fluentui/react-component-ref - ^0.40.0
@fluentui/react-proptypes - ^0.40.0

Danger: ⅹ Failing the build, there is 1 fail.

@@ -1,4 +1,4 @@
# https://help.github.com/articles/about-codeowners/

# Default owners
* @davezuko @kuzhelov @layershifter @levithomason @miroslavstastny @mnajdova
* @davezuko @kuzhelov @layershifter @levithomason @miroslavstastny @mnajdova @kenotron @jdhuntington @ecraig12345 @dzearing @jasongore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this file entirely. It is outdated/incorrect and we don't have areas of ownership to tie to globs.

@@ -41,7 +41,7 @@ const createHookGenerator = (options: KnobGeneratorOptions): null | KnobDefiniti
if (process.env.NODE_ENV !== 'production') {
if (!Component) {
throw new Error(
`Cannot find an export for "${componentInfo.displayName}", please check that it is exported from "@stardust-ui/react"`,
`Cannot find an export for "${componentInfo.displayName}", please check that it is exported from "@fluentui/react"`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that these should have taken a dependency on package.json and just linked to the name. Meh.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, but heh, who would have thought we'd rename a package :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it would be a good change - but I want to keep the diffs pretty plain for now. Maybe a good todo later?

@kenotron kenotron merged commit 25473eb into master Nov 20, 2019
@kenotron kenotron deleted the tooling/fui branch November 20, 2019 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants