-
Notifications
You must be signed in to change notification settings - Fork 53
[tooling] renaming all instances of @stardust-ui to @fluentui #2117
Conversation
Changed dependencies are detected.Changed dependencies in
Changed dependencies are detected.Changed dependencies in
Changed dependencies are detected.Changed dependencies in
Changed dependencies are detected.Changed dependencies in
Generated by 🚫 dangerJS |
Looks like Danger is reporting this: FailuresAll of your entries in CHANGELOG.md should be in the Unreleased section! WarningsPackage (or peer) dependencies changed. Make sure you have approval before merging! MarkdownsChanged dependencies are detected.Changed dependencies in
Changed dependencies are detected.Changed dependencies in
Changed dependencies are detected.Changed dependencies in
Changed dependencies are detected.Changed dependencies in
Danger: ⅹ Failing the build, there is 1 fail. |
@@ -1,4 +1,4 @@ | |||
# https://help.github.com/articles/about-codeowners/ | |||
|
|||
# Default owners | |||
* @davezuko @kuzhelov @layershifter @levithomason @miroslavstastny @mnajdova | |||
* @davezuko @kuzhelov @layershifter @levithomason @miroslavstastny @mnajdova @kenotron @jdhuntington @ecraig12345 @dzearing @jasongore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this file entirely. It is outdated/incorrect and we don't have areas of ownership to tie to globs.
@@ -41,7 +41,7 @@ const createHookGenerator = (options: KnobGeneratorOptions): null | KnobDefiniti | |||
if (process.env.NODE_ENV !== 'production') { | |||
if (!Component) { | |||
throw new Error( | |||
`Cannot find an export for "${componentInfo.displayName}", please check that it is exported from "@stardust-ui/react"`, | |||
`Cannot find an export for "${componentInfo.displayName}", please check that it is exported from "@fluentui/react"`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that these should have taken a dependency on package.json
and just linked to the name
. Meh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, but heh, who would have thought we'd rename a package :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it would be a good change - but I want to keep the diffs pretty plain for now. Maybe a good todo later?
This is part of a multi-step change to converge the future of Fabric and Stardust UI libraries into Fluent UI. Some of this work may not be complete until I have a PR triggered build - so I'm going to keep this open until I get a chance to see what jobs are busted before fixing it up.
What does this include?
What does it NOT include?
What will (should be made to...) work
What will NOT work?