Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Icons): Add new icons to Teams theme #2156

Merged
merged 3 commits into from
Dec 10, 2019
Merged

feat(Icons): Add new icons to Teams theme #2156

merged 3 commits into from
Dec 10, 2019

Conversation

codepretty
Copy link
Collaborator

@codepretty codepretty commented Dec 7, 2019

image

  • volume-down
  • volume
  • volume-up

image

  • presenter
  • no-presenter
Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@miroslavstastny miroslavstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically ok.
Visually the demote is ~1px up compared to promote which can cause an icon to jump in scenarios where you switch from one to the other on click (toolbar). Is that ok?

@codepretty
Copy link
Collaborator Author

Technically ok.
Visually the demote is ~1px up compared to promote which can cause an icon to jump in scenarios where you switch from one to the other on click (toolbar). Is that ok?

Good catch - will see about getting that fixed

@TanelVari
Copy link
Contributor

Updated shapes and renamed presenter SVG-s.

image

@codepretty codepretty merged commit 518c073 into master Dec 10, 2019
@codepretty codepretty deleted the add-new-icons branch December 10, 2019 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants