Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Fix tooltip bug when content is null #2210

Closed
wants to merge 7 commits into from

Conversation

delprzemo
Copy link
Contributor

@delprzemo delprzemo commented Jan 5, 2020

This PR fixes page crash when content is null for tooltip

@delprzemo delprzemo changed the title Fix tooltip bug when content is null #2196 Fix tooltip bug when content is null Jan 5, 2020
@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Jan 5, 2020

Fails
🚫 All of your entries in CHANGELOG.md should be in the **Unreleased** section!

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.57 0.39 1.46:1 2000 1136
🔧 Button.Fluent 1.3 0.17 7.65:1 1000 1299
🔧 Checkbox.Fluent 1.39 0.3 4.63:1 1000 1387
🔧 Dialog.Fluent 0.33 0.16 2.06:1 5000 1658
🔧 Dropdown.Fluent 3.42 0.37 9.24:1 1000 3420
🔧 Icon.Fluent 0.23 0.03 7.67:1 5000 1154
🔧 Image.Fluent 0.1 0.07 1.43:1 5000 475
🔧 Slider.Fluent 1.81 0.28 6.46:1 1000 1805
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 227
🦄 Tooltip.Fluent 0.18 16.83 0.01:1 5000 897

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TextMinimalPerf.default 295 246 1.2:1
ChatDuplicateMessagesPerf.default 786 691 1.14:1
AnimationMinimalPerf.default 638 579 1.1:1
MenuButtonMinimalPerf.default 1977 1830 1.08:1
Button.Fluent 1299 1207 1.08:1
Checkbox.Fluent 1387 1287 1.08:1
LayoutMinimalPerf.default 664 625 1.06:1
SplitButtonMinimalPerf.default 13515 12722 1.06:1
ToolbarMinimalPerf.default 721 681 1.06:1
TreeMinimalPerf.default 962 909 1.06:1
Dialog.Fluent 1658 1574 1.05:1
ButtonSlotsPerf.default 2434 2348 1.04:1
CarouselMinimalPerf.default 2475 2380 1.04:1
ListCommonPerf.default 1411 1353 1.04:1
MenuMinimalPerf.default 2486 2388 1.04:1
ProviderMergeThemesPerf.default 1457 1407 1.04:1
SegmentMinimalPerf.default 1690 1619 1.04:1
AvatarMinimalPerf.default 802 775 1.03:1
PopupMinimalPerf.default 439 425 1.03:1
RefMinimalPerf.default 201 195 1.03:1
TableMinimalPerf.default 717 696 1.03:1
BoxMinimalPerf.default 274 269 1.02:1
DialogMinimalPerf.default 2152 2115 1.02:1
DropdownManyItemsPerf.default 617 602 1.02:1
HeaderMinimalPerf.default 522 512 1.02:1
SliderMinimalPerf.default 2359 2304 1.02:1
TextAreaMinimalPerf.default 3400 3346 1.02:1
FlexMinimalPerf.default 417 411 1.01:1
HierarchicalTreeMinimalPerf.default 1019 1009 1.01:1
IconMinimalPerf.default 1433 1412 1.01:1
ProviderMinimalPerf.default 754 743 1.01:1
ReactionMinimalPerf.default 3245 3209 1.01:1
Image.Fluent 475 470 1.01:1
AttachmentSlotsPerf.default 4635 4647 1:1
ChatMinimalPerf.default 2161 2154 1:1
DropdownMinimalPerf.default 4682 4679 1:1
InputMinimalPerf.default 1202 1201 1:1
ItemLayoutMinimalPerf.default 2101 2102 1:1
AttachmentMinimalPerf.default 1278 1286 0.99:1
DividerMinimalPerf.default 1146 1161 0.99:1
GridMinimalPerf.default 1024 1039 0.99:1
HeaderSlotsPerf.default 1635 1658 0.99:1
LabelMinimalPerf.default 2168 2197 0.99:1
Text.Fluent 227 230 0.99:1
CheckboxMinimalPerf.default 8706 8927 0.98:1
EmbedMinimalPerf.default 7933 8055 0.98:1
Avatar.Fluent 1136 1163 0.98:1
Slider.Fluent 1805 1834 0.98:1
ListMinimalPerf.default 875 910 0.96:1
AlertMinimalPerf.default 739 781 0.95:1
CustomToolbarPrototype.default 3789 4000 0.95:1
ImageMinimalPerf.default 629 671 0.94:1
PortalMinimalPerf.default 296 315 0.94:1
Icon.Fluent 1154 1231 0.94:1
ChatWithPopoverPerf.default 750 806 0.93:1
RadioGroupMinimalPerf.default 503 543 0.93:1
VideoMinimalPerf.default 739 814 0.91:1
FormMinimalPerf.default 934 1034 0.9:1
ButtonMinimalPerf.default 1742 1951 0.89:1
AccordionMinimalPerf.default 241 278 0.87:1
Dropdown.Fluent 3420 3912 0.87:1
LoaderMinimalPerf.default 2714 3165 0.86:1
StatusMinimalPerf.default 964 1141 0.84:1
TooltipMinimalPerf.default 1282 2284 0.56:1
Tooltip.Fluent 897 1820 0.49:1

Generated by 🚫 dangerJS

@delprzemo delprzemo requested a review from levithomason January 9, 2020 14:35
@jurokapsiar
Copy link
Contributor

@delprzemo looks good to me, please update to master and verify if changelog entry gets to the right place (unreleased)

@delprzemo
Copy link
Contributor Author

@delprzemo looks good to me, please update to master and verify if changelog entry gets to the right place (unreleased)

@jurokapsiar Great :) Branch updated to master - changelog entry in the unreleased section. I don't have write access so could you merge it?

@layershifter
Copy link
Member

So, fix for this was merged in #2332. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants