This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
chore(DropdownItem): refactor to functional component with hooks #2382
Merged
silviuaavram
merged 6 commits into
master
from
chore/dropdown-item-functional-component
Feb 25, 2020
Merged
chore(DropdownItem): refactor to functional component with hooks #2382
silviuaavram
merged 6 commits into
master
from
chore/dropdown-item-functional-component
Feb 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf comparison
Potential regressions comparing to master
Perf tests with no regressions
Generated by 🚫 dangerJS |
Looks good 👍 Can you please merge |
99f2e5a
to
fb57c55
Compare
fb57c55
to
0f10ca2
Compare
mnajdova
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please add changelog entry with breaking change, and add in the PR description which props are now passed to the styles function
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired heavily by
ListItem
. Removed the use ofListItem
and created the slots similarly to howListItem
does it. Also added somelistItemStyles
todropdownItemStyles
in order to compensate from not usingListItem
anymore.BREAKING CHANGES
Only limited amount of props are passed to component's styles functions.
DropdownItem
active
isFromKeyboard
selected
hasContent
hasHeader