-
Notifications
You must be signed in to change notification settings - Fork 53
fix(button): removed dotted outline in firefox #390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levithomason
@kuzhelov
pls take a look at my comments
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 41 41
Lines 1341 1341
Branches 197 172 -25
=======================================
Hits 1229 1229
Misses 108 108
Partials 4 4 Continue to review full report at Codecov.
|
83c22b8
to
5f7e5cb
Compare
5f7e5cb
to
18d50bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the changes should be made within normalize -- if we update to a new version of normalize, this change will be lost. Should it go into CustomCSS or siteVariables?
great point, thanks @notandrew - that's definitely would be a better approach 👍 |
…x/button-fix-outline-firefox
@kuzhelov |
[type="reset"]:-moz-focusring, | ||
[type="submit"]:-moz-focusring { | ||
outline: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work in the doc site, is that the intent? If this should be the style for all usages of the Teams theme, including outside of the doc site by consumers, then this should be a staticStyle
in the Teams theme. This way, everywhere the Teams theme is used, there is no outline in Firefox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now yes, the intent was just to address doc site issue and propose a question of whether the same change should be applied for Teams theme.
Button
This PR removes the dotted outline in Firefox for
Button
component. Repro:Firefox
;Before
After