Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(button): removed dotted outline in firefox #390

Merged
merged 7 commits into from
Oct 30, 2018
Merged

fix(button): removed dotted outline in firefox #390

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
18d50bd
fix(button): removed dotted outline in firefox
bmdalex Oct 22, 2018
4bf39c9
Merge branch 'master' into fix/button-fix-outline-firefox
Oct 23, 2018
33709b0
Merge branch 'master' into fix/button-fix-outline-firefox
Oct 23, 2018
5a5d43c
Merge branch 'master' of https://github.com/stardust-ui/react into fi…
bmdalex Oct 24, 2018
0f57318
addressed comments following suggestions
bmdalex Oct 24, 2018
900c1fa
Merge branch 'master' into fix/button-fix-outline-firefox
kuzhelov-ms Oct 30, 2018
7b7a541
refine changelog entry
kuzhelov-ms Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Fixes
- Fix build on Windows @jurokapsiar ([#383](https://github.com/stardust-ui/react/pull/383))
- Add warning for rendering components outside provider @Bugaa92 ([#378](https://github.com/stardust-ui/react/pull/378))
- Fix for dotted focus outline in Firefox for `Button` component @Bugaa92 ([#390](https://github.com/stardust-ui/react/pull/390))

### Features
- Export `mergeThemes` @levithomason ([#285](https://github.com/stardust-ui/react/pull/285))
Expand Down
7 changes: 7 additions & 0 deletions docs/src/Style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,11 @@ export const semanticCssOverrides = `
color: rgba(255,255,255,.7)!important;
cursor: not-allowed!important;
}

button:-moz-focusring,
[type="button"]:-moz-focusring,
[type="reset"]:-moz-focusring,
[type="submit"]:-moz-focusring {
outline: 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work in the doc site, is that the intent? If this should be the style for all usages of the Teams theme, including outside of the doc site by consumers, then this should be a staticStyle in the Teams theme. This way, everywhere the Teams theme is used, there is no outline in Firefox.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now yes, the intent was just to address doc site issue and propose a question of whether the same change should be applied for Teams theme.

`