-
Notifications
You must be signed in to change notification settings - Fork 53
docs(ChatPane): Add attachments and link to chat pane messages in prototype #514
Conversation
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 42 42
Lines 1455 1455
Branches 212 212
=======================================
Hits 1283 1283
Misses 167 167
Partials 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one small note, LGTM
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good, have tested it locally and it is behaving as in the description. However, it is a bit overwhelming for all messages to have attachments. Can you at least add the attachments on every 5th message let's say? Will approve after this change. No other changes required from my side.
This PR aims to improve chat pane behavior by adding Attachments and links to chat message so provide the proper accessibility experience for it.
Opened context menu:
