This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
refactor: move rules and variables to themes/teams #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
- Coverage 86.92% 85.88% -1.05%
==========================================
Files 75 74 -1
Lines 1178 1098 -80
Branches 215 224 +9
==========================================
- Hits 1024 943 -81
- Misses 148 149 +1
Partials 6 6
Continue to review full report at Codecov.
|
levithomason
commented
Aug 8, 2018
| return Object.keys(rules).reduce((acc, ruleName) => { | ||
| acc[ruleName] = renderRule(rules[ruleName], ruleProps) | ||
| return Object.keys(styles).reduce((acc, styleName) => { | ||
| acc[styleName] = renderRule(styles[styleName], styleProps) |
There was a problem hiding this comment.
Note, renderRule is part of the fela API, hence, it is not changed.
levithomason
force-pushed
the
chore/move-theme-files
branch
from
9420470 to
7402cc3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breakout of #16:
Changes
src/themes/teams/components.Fixes
Textstyles were directly importingsiteVariables, which is not allowed. ThetextVariableswere updated to compose thesiteVariables. Now,textStylessimply uses thetextVariablesit receives as part of its argument.ListItemvariables were defined inlistVariables. Those have been moved tolistItemVariables. The redundantitem*prefixes were removed from the variable names.Changelog
No entry as this is a refactor that does not affect consumers.