This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore: introduce mergeThemes function #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov and
mnajdova
as code owners
levithomason
commented
Aug 8, 2018
| }, | ||
| "esSpecCompliant": true | ||
| } | ||
| ], |
There was a problem hiding this comment.
Fixes error with trailing comma after rest operator. Without this, TS requires a trailing comma but adding one is also a TS error.
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 85.88% 85.89% +0.01%
==========================================
Files 74 74
Lines 1098 1099 +1
Branches 215 215
==========================================
+ Hits 943 944 +1
Misses 149 149
Partials 6 6
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another breakout of #16.
👉 The best way to review the features is to review
mergeThemes-test.ts. This gives 100% coverage of all the functionality introduced to what will be the public API.This PR introduces the
mergeThemesfunction. This function is not used anywhere currently. It is introduced separately here to introduce the typings, tests, and patterns we'll use for merging themes in nested Providers.The next phase will be implementing theme merging in nested Providers.