Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

refactor: simplify ContributionPrompt and remove customCSS #68

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Aug 9, 2018

This is a breakout of ContributionPrompt cleanup form #16.

We had inline styles and an extra div applied to each instance of the contribution prompt. This just removes those styles, removes the docs/src/utils/customCSS file, and cleans up / simplifies the prompt.

It largely works and looks the same:

image

image

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files          74       74           
  Lines        1101     1101           
  Branches      216      216           
=======================================
  Hits          946      946           
  Misses        149      149           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b3831...23be8d7. Read the comment docs.

@levithomason levithomason merged commit cf9d739 into master Aug 9, 2018
@levithomason levithomason deleted the refactor/contribution-prompt branch August 9, 2018 05:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant